Reset EntityManager via reinitialization, instead of removing from container #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3l1x
reviewed
Jul 16, 2024
| $this->container->removeService($name); | ||
| /** @var EntityManagerDecorator $manager */ | ||
| $manager = $this->container->getService($name); | ||
| $wrapped = $this->container->createInstance(\Doctrine\ORM\EntityManager::class); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes situations, when entity manager is closed properly - because removing the EntityManager from container does not fix closed entity manager in existing instances of services in DI container - it can be achieved only this way.
Inspired by how it is solved in Symfony framework.
Tested and it works, tested only with single entity manager / connection, can not guarantee this will work with multiple connections.