[release-4.6] Fix dns_option typo and add test of container create with DNS option #448
Conversation
Signed-off-by: Robb Manes <[email protected]> (cherry picked from commit 8b2a77d) Signed-off-by: Jan Rodák <[email protected]>
Signed-off-by: Jan Rodák <[email protected]> (cherry picked from commit 464dfd8) Signed-off-by: Jan Rodák <[email protected]>
|
thanks. pylint is complaining but you could try backporting this commit to make it happy |
Two ways of fixing this:
- Ignore R0917 for internal functions such as __int__
- Fix the positional arguments with *
Only exception is for run(image, command=None) for which it is
convenient to run with two positional args.
Example:
run('fedora:latest', 'ls -la /')
Testing against Pylint stable.
Source of Pylint 3.3.1 docs
https://pylint.readthedocs.io/en/stable/user_guide/messages/refactor/too-many-positional-arguments.html
Signed-off-by: Nicola Sella <[email protected]>
(cherry picked from commit 210c9dc)
Signed-off-by: Jan Rodák <[email protected]>
|
@inknos Unfortunately this didn't help probably will have to backport the other commits. What commits should I backport next? |
|
@jwhonce any thoughts on the errors in this PR? |
Honny1
force-pushed
the
dev/jrodak/dns-options
branch
2 times, most recently
from
f64a8ab
to
9f3eee9
Compare
Signed-off-by: Jan Rodák <[email protected]>
Signed-off-by: Jan Rodák <[email protected]>
Honny1
force-pushed
the
dev/jrodak/dns-options
branch
from
9f3eee9
to
15d8b2f
Compare
containers/automation_images#376 Signed-off-by: Nicola Sella <[email protected]> (cherry picked from commit fd601b2) Signed-off-by: Jan Rodák <[email protected]>
Signed-off-by: Urvashi Mohnani <[email protected]> (cherry picked from commit 9b2af6e) Signed-off-by: Jan Rodák <[email protected]>
|
since #449 jobs passed I want to give one more run to packit to see what's wrong. Otherwise the PR looks good. |
|
/packit build |
|
the issue looks unrelated to me /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, inknos, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Just make it go, I'll add myself if needed in the future (I am already approver on main branch) and since Jan did already many rebases (due to pylint failures) I only wish for this PR to be merged 😆 |
|
/hold cancel |
openshift-merge-bot
bot
merged commit 79d7acd
into
containers:release-4.6
This PR backports fixes a typo in dns_option and adds a DNS option container creation test to version 4.6.
Fixes: https://issues.redhat.com/browse/RHEL-31069