-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include py.typed marker file. #381
Include py.typed marker file. #381
Conversation
@jnsnow PTAL, TIA |
Any updates on this? This is only adding one single, entirely empty marker file; is this connected to any considerations? |
Thank you @jonded94! Can you please rebase with upstream and sign your commit and repush, I think that should help fix the DCO and gating failure. Changes LGTM |
39a4554
to
32fa6aa
Compare
Did a rebase and a force repush, with a signed commit (which also shows to be verified in Github), but unfortunately that DCO job still fails? |
I believe DCO is failing because your commit doesn't have the |
Signed-off-by: Jonas Dedden <[email protected]>
32fa6aa
to
5f31809
Compare
Tests seem to run through now, thanks for your help! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonded94, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm using this package in codebases checked with common static type checking tools, such as
mypy
. Unfortunately, it will error:This was already apparent in #293. Including this file would at least enable checking against the many type hints that are already a part of this library and would help massively.