-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Node.js chatbot recipe #2152
base: main
Are you sure you want to change the base?
Conversation
1085056
to
3d6c2da
Compare
In case it matters, as an FYI I did talk to @slemeur about adding this recipe in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm from the upstream ai-lab perspective
Just realised this will need an update for |
packages/backend/src/assets/ai.json
Outdated
"description": "This is a Node.js based chat demo application.", | ||
"name": "Node.js based ChatBot", | ||
"repository": "https://github.com/containers/ai-lab-recipes", | ||
"ref": "v1.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the sources at the tag 1.3.0. I suppose it should be 1.3.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I rename the tag (as I wrongly named it) and the latest is now v1.3.3.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But because of the fix I think it need a new tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as commented below, we need this PR to land containers/ai-lab-recipes#825 and then a new tag and then we can update this PR to point to that tag.
This one last PR needs to land, and then I'll update this PR to point to the release which contains that update containers/ai-lab-recipes#825 |
dd4d479
to
168f660
Compare
Just merged 825, /unhold |
You can use commit SHA instead of tag for the reference, we'll use the tag when we will release the extension |
Signed-off-by: Michael Dawson <[email protected]>
Signed-off-by: Michael Dawson <[email protected]>
Signed-off-by: Michael Dawson <[email protected]>
07e3d19
to
bbff155
Compare
@jeffmaury, @feloy updated to use the SHA. Should be good to go now assuming you will squash the commits as it is landed. |
@@ -86,6 +86,23 @@ | |||
], | |||
"backend": "llama-cpp" | |||
}, | |||
{ | |||
"id": "chatbot-nodejs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"id": "chatbot-nodejs", | |
"id": "chatbot-nodejs-react", |
as we are now usin the pattern feat-language-framemork now
What does this PR do?
NOTE: this should land after - containers/ai-lab-recipes#822
Adds the Node.js chatbot example to the recipes included in podman-ai-lab
Screenshot / video of UI
What issues does this PR fix or reference?
JavaScript and TypeScript are often the second language supported by leading Libraries like Langchain, llamaindex and ollama indicating AI community believes they will be important for integrating AI into applications. We should have at least a few Node.js/Javascript recipes.
How to test this PR?