Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Node.js chatbot recipe #2152

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mhdawson
Copy link

What does this PR do?

NOTE: this should land after - containers/ai-lab-recipes#822

Adds the Node.js chatbot example to the recipes included in podman-ai-lab

Screenshot / video of UI

What issues does this PR fix or reference?

JavaScript and TypeScript are often the second language supported by leading Libraries like Langchain, llamaindex and ollama indicating AI community believes they will be important for integrating AI into applications. We should have at least a few Node.js/Javascript recipes.

How to test this PR?

  1. Clone podman-desktop repo, build as instructed in the contributing instrctions
  2. Cone the repo/branch for this pull request in podman-desktop-extension-ia-lab a the same level as 1)
  3. Build podman-desktop-extension-ai-lab as indicated in the contributing info
  4. Start podman-desktop as indicated in the contributing info for podman-desktop-extension-ai-lab
  5. Go to the recipes and select and start the Node.js chatbot recipe.
  6. Once everything is started validate that you can use the link on the details page for the running instance to get to the UI for the chatbot.

@mhdawson
Copy link
Author

In case it matters, as an FYI I did talk to @slemeur about adding this recipe in advance.

Copy link

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm from the upstream ai-lab perspective

@mhdawson
Copy link
Author

Just realised this will need an update for "ref": "v1.3.0", to be updated to one that includes the fix in the ai-lab-recipies repo. Either that or point to a specific sha as the java one does ?

"description": "This is a Node.js based chat demo application.",
"name": "Node.js based ChatBot",
"repository": "https://github.com/containers/ai-lab-recipes",
"ref": "v1.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the sources at the tag 1.3.0. I suppose it should be 1.3.0.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I rename the tag (as I wrongly named it) and the latest is now v1.3.3.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But because of the fix I think it need a new tag

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as commented below, we need this PR to land containers/ai-lab-recipes#825 and then a new tag and then we can update this PR to point to that tag.

@mhdawson
Copy link
Author

This one last PR needs to land, and then I'll update this PR to point to the release which contains that update containers/ai-lab-recipes#825

@Gregory-Pereira
Copy link

Just merged 825, /unhold

@jeffmaury
Copy link
Contributor

This one last PR needs to land, and then I'll update this PR to point to the release which contains that update containers/ai-lab-recipes#825

You can use commit SHA instead of tag for the reference, we'll use the tag when we will release the extension

@jeffmaury jeffmaury mentioned this pull request Nov 26, 2024
6 tasks
@mhdawson
Copy link
Author

@jeffmaury, @feloy updated to use the SHA. Should be good to go now assuming you will squash the commits as it is landed.

@@ -86,6 +86,23 @@
],
"backend": "llama-cpp"
},
{
"id": "chatbot-nodejs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"id": "chatbot-nodejs",
"id": "chatbot-nodejs-react",

as we are now usin the pattern feat-language-framemork now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants