Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve an error message #2595

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Improve an error message #2595

merged 1 commit into from
Nov 21, 2024

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Oct 10, 2024

We are seeing

reference "[overlay@...]quay.io/...@sha256:..." does not resolve to an image ID: identifier is not an image

which is misleading; hide the ErrNoSuchImage text.

@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2024

LGTM

mtrmac added a commit to mtrmac/skopeo that referenced this pull request Oct 14, 2024
containers/image#2595 will change it.

Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac added a commit to mtrmac/skopeo that referenced this pull request Oct 14, 2024
@mtrmac
Copy link
Collaborator Author

mtrmac commented Oct 14, 2024

The Skopeo failures should be fixed by containers/skopeo#2442 , that is being tested in containers/skopeo#2441 .

@mtrmac mtrmac force-pushed the error-text branch 2 times, most recently from a174fb3 to 6afd8b0 Compare October 24, 2024 13:03
mtrmac added a commit to mtrmac/skopeo that referenced this pull request Oct 25, 2024
containers/image#2595 will change it.

Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac added a commit to mtrmac/skopeo that referenced this pull request Oct 25, 2024
mtrmac added a commit to mtrmac/skopeo that referenced this pull request Oct 25, 2024
mtrmac added a commit to mtrmac/skopeo that referenced this pull request Nov 15, 2024
containers/image#2595 will change it.

Signed-off-by: Miloslav Trmač <[email protected]>
We are seeing
> reference "[overlay@...]quay.io/...@sha256:..." does not resolve to an image ID: identifier is not an image

which is misleading; hide the ErrNoSuchImage text.

Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac added a commit to mtrmac/skopeo that referenced this pull request Nov 19, 2024
mtrmac added a commit to mtrmac/skopeo that referenced this pull request Nov 20, 2024
containers/image#2595 will change it.

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac mtrmac merged commit fdfb166 into containers:main Nov 21, 2024
10 checks passed
@mtrmac mtrmac deleted the error-text branch November 21, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants