Config files should live in /usr/local on FreeBSD (highlight in release notes!)

[dfr]

Signed-off-by: Doug Rabson [email protected]

[vrothberg]

Thanks for contributing!

[lsm5]

LGTM. Needs rebase though.

Also, do we need something FreeBSD specific in CI going forrward?

[dfr]

Good point - I can add something to Makefile as a followup PR.

[mtrmac]

There are three other /etc paths in c/image/docker; should those be updated as well?

---

Compare containers/skopeo#1298 (comment) / containers/skopeo#1507 . Changing the default in c/image instead of Skopeo is definitely better, still…

• Changing the default is going to immediately break Skopeo’s Makefile that installs config files to /etc.
• How are upgrades going to work? Why isn’t this going to, potentially silently, ignore existing user’s configuration (with security implications like ignoring blocked registry configurations)? At least for users that used to compile themselves using e.g. Skopeo’s Makefile, this seems to me to be an unavoidable compatibility break. Or is there some reason why that isn’t actually possible, so it isn’t relevant?

[mtrmac]

(Absolutely non-blocking: Naming this pkg/sysregistriesv2/paths_{common,freebsd}.go would work just as well, and be a tiny bit more descriptive.)

[mtrmac]

(Absolutely non-blocking: Naming this pkg/sysregistriesv2/policy_paths_{common,freebsd}.go would work just as well, and be a tiny bit more descriptive.)

[dfr]

There are three other /etc paths in c/image/docker; should those be updated as well?

I don't think there is a fully functioning docker for FreeBSD at this point. I know some people were working on porting moby but I'm not sure of the status there.

Compare containers/skopeo#1298 (comment) / containers/skopeo#1507 . Changing the default in c/image instead of Skopeo is definitely better, still…

• Changing the default is going to immediately break Skopeo’s Makefile that installs config files to /etc.
• How are upgrades going to work? Why isn’t this going to, potentially silently, ignore existing user’s configuration (with security implications like ignoring blocked registry configurations)? At least for users that used to compile themselves using e.g. Skopeo’s Makefile, this seems to me to be an unavoidable compatibility break. Or is there some reason why that isn’t actually possible, so it isn’t relevant?

This is a good point but perhaps not a big issue - I think there are only a handful of people using skopeo on FreeBSD at this point since its not available as a pre-build package. I can follow up with a PR on skopeo to install to the correct path.

[mtrmac]

There are three other /etc paths in c/image/docker; should those be updated as well?

I don't think there is a fully functioning docker for FreeBSD at this point

This is for the “container image registry” client (incl. podman pull), it has nothing to do with /usr/bin/docker.

[mtrmac]

• How are upgrades going to work? Why isn’t this going to, potentially silently, ignore existing user’s configuration (with security implications like ignoring blocked registry configurations)? At least for users that used to compile themselves using e.g. Skopeo’s Makefile, this seems to me to be an unavoidable compatibility break. Or is there some reason why that isn’t actually possible, so it isn’t relevant?

This is a good point but perhaps not a big issue - I think there are only a handful of people using skopeo on FreeBSD at this point since its not available as a pre-build package

I am unhappy about this in principle, but ultimately I do think it’s appropriate for FreeBSD contributors to decide on the FreeBSD tradeoffs…

RFC @mateuszkwiatkowski (also @vrothberg @lsm5 )

[mtrmac]

Also, do we need something FreeBSD specific in CI going forrward?

At least to the extent Red Hat is paying for the CI, I wouldn’t say we need FreeBSD coverage. Still, it’s a good idea to explore this, probably in a separate PR. (I guess adding FreeBSD to the cross test would be a cheap and easy smoke test. Modifying all of Skopeo’s integration/system testing to run on FreeBSD seems intuitively hard, but I know very little about FreeBSD capabilities.)

[vrothberg]

SGTM ✔️

[dfr]

I changed the file names along the lines suggested by @mtrmac and made a similar change in docker/.

For skopeo, I opened containers/skopeo#1642 which changes the Makefile to match. The Makefile in skopeo unconditionally overwrites policy.json and after the change will write the default policy to the new location. Are there release notes for skopeo releases? Perhaps the change can be mentioned there.

[rhatdan]

LGTM

[mtrmac]

Thanks again!

[mtrmac]

Are there release notes for skopeo releases? Perhaps the change can be mentioned there.

GitHub does have a release notes mechanism. We don’t currently have automated mechanism to collect/create them for c/image or Skopeo. I have, at least, re-titled the PRs; hopefully that helps us remember when the time comes.