Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Replace docker/distribution/reference with containerd/reference/docker #1438

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

zhsj
Copy link
Contributor

@zhsj zhsj commented Apr 13, 2020

Since containerd/containerd#3728
The docker/distribution/reference package is copied into containerd core

@k8s-ci-robot
Copy link

Hi @zhsj. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhsj
Copy link
Contributor Author

zhsj commented Apr 13, 2020

This updates #1377, so no need a new docker/distribution release.

cc @chenrui333

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
nit.. we usually do vendor changes on a separate commit..

@mikebrow
Copy link
Member

/ok-to-test

@zhsj
Copy link
Contributor Author

zhsj commented Apr 14, 2020

/retest

@k8s-ci-robot
Copy link

@zhsj: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cri-containerd-windows-cri 84bebb4 link /test pull-cri-containerd-windows-cri

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikebrow
Copy link
Member

@zhsj pls rebase.. pull-cri-containerd-windows-cri test has been moved to git hub actions.

Since containerd/containerd#3728
The docker/distribution/reference package is copied into containerd core

Signed-off-by: Shengjing Zhu <[email protected]>
@zhsj
Copy link
Contributor Author

zhsj commented Apr 15, 2020

@zhsj pls rebase.. pull-cri-containerd-windows-cri test has been moved to git hub actions.

Done, and commit is also split.

@mikebrow mikebrow added the lgtm label Apr 15, 2020
@mikebrow mikebrow merged commit 68a84f7 into containerd:master Apr 15, 2020
@zhsj zhsj deleted the use-containerd-reference branch April 15, 2020 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants