yarn: Resolve dev dependencies #744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimreaper35
requested review from
a-ovchinnikov,
eskultety and
taylormadore
slimreaper35
force-pushed
the
yarn-classic-dev
branch
2 times, most recently
from
78c6aec
to
5f7cc8a
Compare
Add utility functions to identify runtime dependencies in Yarn Classic projects: - Implement find_runtime_deps() to identify production dependencies across workspaces - Support compound key expansion in yarn.lock files - Use BFS algorithm for efficient transitive dependency resolution This enables proper classification of runtime dependencies based on their usage in package.json files and transitive relationships. Signed-off-by: Michal Šoltis <[email protected]>
Integrate dev dependency detection into the package resolution process: - Add dev flag to YarnClassicPackageFactory - Pass non-dev dependencies set through the resolution chain - Update package creation to mark dependencies as dev/non-dev - Update tests to accommodate the new dev flag This completes the dependency classification implementation by marking each resolved package with its development status. Signed-off-by: Michal Šoltis <[email protected]>
slimreaper35
force-pushed
the
yarn-classic-dev
branch
from
5f7cc8a
to
6636944
Compare
slimreaper35
changed the title
| "version": "2.0.0", | ||
| "dependencies": {"multi-dep1": "^4.0.0", "multi-dep2": "^4.0.0"}, | ||
| }, | ||
| "multi-dep1@^4.0.0, multi-dep2@^4.0.0": {"version": "5.0.0", "dependencies": {}}, |
There was a problem hiding this comment.
Isn't _expand_yarn_lock_keys supposed to split this key in two?
| "dev-dep1@^4.0.0": {"version": "4.0.0", "dependencies": {}}, | ||
| } | ||
|
|
||
| result = find_runtime_deps(package_json, mock_yarn_lock, []) |
There was a problem hiding this comment.
Should there be a test for Note: If a dependency is marked as runtime dependency somewhere and as a development dependency somewhere else, it is classified as runtime? E.g. by having a simple workspace where dev-dep1 is a runtime dependency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test(as is the standard for Pipelines as Code)