Skip to content

Commit

Permalink
fix: deduce AutoID from field info
Browse files Browse the repository at this point in the history
Resolves: milvus-io#654

Signed-off-by: Congqi Xia <[email protected]>
  • Loading branch information
congqixia committed Jan 17, 2024
1 parent 51de7f0 commit b471b95
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 3 additions & 1 deletion entity/schema.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,13 @@ func (s *Schema) ProtoMessage() *schema.CollectionSchema {

// ReadProto parses proto Collection Schema
func (s *Schema) ReadProto(p *schema.CollectionSchema) *Schema {
s.AutoID = p.GetAutoID()
s.Description = p.GetDescription()
s.CollectionName = p.GetName()
s.Fields = make([]*Field, 0, len(p.GetFields()))
for _, fp := range p.GetFields() {
if fp.GetAutoID() {
s.AutoID = true
}
s.Fields = append(s.Fields, NewField().ReadProto(fp))
}
s.EnableDynamicField = p.GetEnableDynamicField()
Expand Down
1 change: 0 additions & 1 deletion entity/schema_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ func (s *SchemaSuite) TestBasic() {
nsch = nsch.ReadProto(p)

s.Equal(sch.CollectionName, nsch.CollectionName)
s.Equal(sch.AutoID, nsch.AutoID)
s.Equal(sch.Description, nsch.Description)
s.Equal(sch.EnableDynamicField, nsch.EnableDynamicField)
s.Equal(len(sch.Fields), len(nsch.Fields))
Expand Down

0 comments on commit b471b95

Please sign in to comment.