-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.10.0 h7e5bf1 #5
Conversation
…nda-forge-pinning 2022.11.01.00.02.24
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
It looks like it has a memory issue on the liking phase
Not sure yet how to proceed here, maybe there is a way to have the linking phase consuming less memory or maybe we could increase the memory on CI ... |
Hmm, that is an issue, not sure if we could use a different linker under linux e.g. |
@conda-forge-admin please rerender |
…nda-forge-pinning 2022.11.15.11.53.06
Also, how did you discern that it hat the exit-code or |
I suppose option B could be a solution as listed here: https://github.com/ziglang/zig/wiki/Building-Zig-From-Source#option-b-use-a-pre-built-zig-binary |
Before the error 2 has an error 137 |
Not sure if it would fix the problem, but it uses mamba instead of conda for building the package.@ocefpaf told me that mamba is faster but consumes more memory so maybe you could try to replace here mamba by conda zig-feedstock/.scripts/build_steps.sh Line 60 in 62269ba
So there, change "conda mambabuild" to "conda build" |
I think our experience was that mamba uses less memory :) (at least that is what the readthedocs people found!). |
Maybe my info is outdated then. To be fair, I only use micromamba lately :-) |
no objection from my side, maybe we could try it and check with the conda-forge core if it is a valid approach here. |
Might be wise indeed, it will also make the compile take a lot longer.. Not sure how homebrew for example is dealing with this, they seem to be using Option A). Also, they are linking statically, which I assume would use at least use as much memory or more when compared to linking dynamically. @wolfv @ocefpaf any idea what the max amount of memory is in the Azure VM? |
it seems this PR fixed the problem: ziglang/zig#13560 @ocefpaf what would be a better approach to have it here? |
Usually we patch small things but those changes are 68 commits and 579 file changes!!! What are the chances of getting a new release? If not, one alternative is to get the source from that commit but publish it as a dev release following CFEP-05. |
got it .. thanks for the explanation @ocefpaf ! appreciate that |
Probably this will be included in the next zig release I suppose, but then you would be missing 0.10 from conda-forge |
@ocefpaf , the estimate data for that is by the end of may: https://github.com/ziglang/zig/milestone/17
@tdejager is it something that you would like to work on? |
…nda-forge-pinning 2022.12.09.08.14.11
@wolfv is trying with more memory (swap) in the Azure vm. Which would still be the easiest I think |
Seems like 2 things going on:
|
I checked, and that file ( |
Worst case adding a symlink might work (is statically linked anyways), haha ( |
@tdejager , is it something you could do? Thanks |
Nowadays you can also create a swapfile, but I think only for linux runners. https://github.com/conda-forge/polars-feedstock/blob/81713313ff444aea8c755d9e4fcb7102555dde3a/conda-forge.yml#L13-L15 |
Do we need 0.10.0 specifically or would 0.11.0 be ok? Asking since that release came out a couple months ago so is a bit more recent (and may have addressed some of these build issues) |
I tried v0.11.0 in #9. One major problem is that zig requires glibc >=2.25. Not sure how this is handled in conda-forge packages. |
Oh interesting. Maybe we should try 0.10.1 first then |
@wolfv Do you think we still need 0.10.0? I think I have an acceptable 0.13.0 build recipe for linux x86_64/aarch64 and osx. If so, I would prefer to build it with the newer recipe in a separate branch |
It looks like we are already on 0.12.0: #10 Maybe we should close? Thanks all for the efforts on getting this updated! 🙏 |
@jakirkham Yes, I'd prefer close and reopen as a separate branch if needed. We are actually on We are having a lot of difficulties with |
Please go ahead with a new PR. We can discuss CI setup in that PR |
Closing. If needed, we will create a branch from the latest recipe |
Checklist
conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering) yes, took the automatic PR as a baseThis PR attempts to use the latest version of zig, and also tries to build for osx. But there are still some issues with that, opening it here so it will also run in CI.