Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch #161

Merged
merged 8 commits into from
Aug 22, 2023
Merged

Add aarch #161

merged 8 commits into from
Aug 22, 2023

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Aug 18, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@pavelzw pavelzw closed this Aug 18, 2023
@pavelzw pavelzw reopened this Aug 18, 2023
@pavelzw
Copy link
Member Author

pavelzw commented Aug 18, 2023

Seems to work with conda-forge/conda-smithy#1751

@0xbe7a 0xbe7a mentioned this pull request Aug 19, 2023
5 tasks
recipe/meta.yaml Outdated Show resolved Hide resolved
@0xbe7a 0xbe7a force-pushed the aarch branch 3 times, most recently from 8f8537b to aff16c3 Compare August 19, 2023 16:36
@xhochy
Copy link
Member

xhochy commented Aug 20, 2023

One caveat: This will break automerge as that will rerender with the conda-smity release version.

@pavelzw
Copy link
Member Author

pavelzw commented Aug 20, 2023

Should we wait until conda-forge/conda-smithy#1751 is released?

@xhochy
Copy link
Member

xhochy commented Aug 21, 2023

If @pavelzw and @0xbe7a commit to rerender with the conda-smithy PR until it is released, I'm fine with merging this.

Note for the reader: I work together with them ;)

@0xbe7a
Copy link
Member

0xbe7a commented Aug 21, 2023

Sure, if the conda-smithy PR takes longer than a couple of weeks to merge we can also just setup the swap by hand and not have to manually rerender for eternity.

@xhochy xhochy merged commit d364169 into conda-forge:main Aug 22, 2023
27 checks passed
@0xbe7a 0xbe7a deleted the aarch branch August 22, 2023 07:18
This was referenced Aug 22, 2023
@jonashaag
Copy link

Nice work <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants