Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild for CUDA 12 w/arch support #51

Merged
merged 11 commits into from
Oct 6, 2023
Merged

Rebuild for CUDA 12 w/arch support #51

merged 11 commits into from
Oct 6, 2023

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

Here are some more details about this specific migrator:

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems see this issue. Please feel free to raise any issues encountered there. Thank you! 🙏

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6028280553, please use this URL for debugging.

@regro-cf-autotick-bot
Rebuild for CUDA 12 w/arch support
2c8a259 
The transition to CUDA 12 SDK includes new packages for all CUDA libraries and
build tools. Notably, the cudatoolkit package no longer exists, and packages
should depend directly on the specific CUDA libraries (libcublas, libcusolver,
etc) as needed. For an in-depth overview of the changes and to report problems
[see this issue]( conda-forge/conda-forge.github.io#1963 ).
Please feel free to raise any issues encountered there. Thank you! 🙏
@regro-cf-autotick-bot
MNT: Re-rendered with conda-build 3.26.1, conda-smithy 3.24.1, and co…
08c4062 
…nda-forge-pinning 2023.08.30.17.25.59
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Aug 30, 2023
@kkraus14
Copy link
Contributor

Let's hold until 23.08 update is in 😄

@jakirkham
Copy link
Member

Yeah removed automerge here and added to your PR

That said, 23.06 does support CUDA 12 (and was migrated before). This just adds other architectures

@kkraus14
Copy link
Contributor

That said, 23.06 does support CUDA 12 (and was migrated before). This just adds other architectures

Ah, maybe lets land this then first? Would be nice to have CUDA 12 23.06 packages 😄

@jakirkham
Copy link
Member

Ok either way

@jakirkham
Sort conda-forge.yml keys
1881a86 
Should avoid no-op migrations that do this by default.
@jakirkham
Free up space on Azure images
a2ef91d 
Hopefully fixes the memory errors on arch builds.
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@jakirkham
Copy link
Member

Saw a memory issue in the arch builds. Added changes to clean up the CI images

If that doesn't work, we may need to add a swap file ( conda-forge/conda-smithy#1751 ) (pending a conda-smithy release)

@jakirkham jakirkham mentioned this pull request Aug 30, 2023
Closed
5 tasks
@kkraus14
Copy link
Contributor

Yea, looks like the memory issues continue. How about only building the tests if we're in linux_64? Mostly wanted to just confirm dependency upgrades aren't breaking things.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

conda-forge-webservices[bot] and others added 2 commits August 31, 2023 18:18
@jakirkham
Copy link
Member

@conda-forge-admin, please re-render

@jakirkham
Copy link
Member

Yea, looks like the memory issues continue.

Looks like there is a new conda-smithy release. So tried added the swap file change

How about only building the tests if we're in linux_64? Mostly wanted to just confirm dependency upgrades aren't breaking things.

Would also be ok with that if this doesn't work

jakirkham
jakirkham reviewed Aug 31, 2023
View reviewed changes
conda-forge.yml
azure:
free_disk_space: true
settings_linux:
swapfile_size: 10GiB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing the same error. Not sure what we should bump this too. Any thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really unsure where there's a lot of "weird environment" in the loop here. The fact that different components are failing with signal 11 points to environment from my perspective.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC the feedstock is using emulation for arch builds. Could that be an issue? Should we use cross-compilation or native builds?

librmm-feedstock/conda-forge.yml

Lines 9 to 11 in f0423fb

provider:
linux_aarch64: azure
linux_ppc64le: azure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only building tests to ensure dependency version changes don't break downstream usage of RMM headers. I would prefer to keep the setup as simple as possible where the easiest path forward would possibly be to just only build the tests on linux-64?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds ok to me

@kkraus14
Copy link
Contributor

kkraus14 commented Oct 5, 2023

🎉 @jakirkham @leofang could one of you take a look so we can land this, then land the 11.8 rebuild, then the 23.08 upgrade? 😆

@leofang
Copy link
Member

leofang commented Oct 6, 2023

Sorry for delay, LGTM

@kkraus14 kkraus14 merged commit 98caed2 into conda-forge:main Oct 6, 2023
7 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-cuda120-0-2_hb535c6 branch October 6, 2023 18:43
@jakirkham
Copy link
Member

Thanks Keith & Leo! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@jakirkham jakirkham jakirkham left review comments

@leofang leofang leofang approved these changes

@rlratzel rlratzel Awaiting requested review from rlratzel rlratzel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@regro-cf-autotick-bot @kkraus14 @jakirkham @leofang