Make the python_min linter check robust against if-else syntax
#2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `noarch: python` recipes, the thing being checked here should always have `python` as a string and not in an `if:` block, so it should be safe to skip the check. Fixes the linter failing on rattler-build recipes with conditional requirements.
beckermr
requested changes
Nov 21, 2024
beckermr
approved these changes
Nov 26, 2024
|
Thanks for fixing that @beckermr! And sorry for the slow follow-up, I had little time for the past week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
noarch: pythonrecipes, the thing being checked here should always havepythonas a string and not in anif:block, so it should be safe to skip the check. Fixes the linter failing on rattler-build recipes with conditional requirements.Closes gh-2153