-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost] Add default support for from_exception in non intel platforms #23881
[boost] Add default support for from_exception in non intel platforms #23881
Conversation
Signed-off-by: Uilian Ries <[email protected]>
🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'. 👋 @grafikrobot @Hopobcn @jwillikers @paulharris you might be interested. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot :)
Does this fix your problem @randomphrase?
@RubenRBS Sorry, I forgot to post the test result using GCC in Mac: Without the change
With the change:
|
This comment has been minimized.
This comment has been minimized.
Looks like it will, although I haven't quite worked out how to test this locally. Thanks for the quick response! |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit f66afa0boost/1.85.0@#e2105194df7c6cc61e0ab0e73680107c
boost/1.84.0@#0980540592b2d2d09100066a5ad1dc74
boost/1.82.0@#6ff3efefc646f1ba135918591856fd6e
boost/1.83.0@#1f48cdfa587526640515a1b6063ef672
boost/1.81.0@#f1e3e6d121dd525666493a7d00881dbd
boost/1.79.0@#14b359c785c10f1a9dc79de127213d72
boost/1.76.0@#fc2f7750406631d83259c65a133513a1
boost/1.77.0@#baa8aeefa711fd84e9f1fbd2f1c52119
boost/1.74.0@#3e36fb96b19a26494e6c03b9bfb5acaf
boost/1.73.0@#76be5ccd19f9827f9c8ddb51548b1353
boost/1.72.0@#647c623ed438b86e0e9583bca27f8b62
boost/1.71.0@#7836c5f505b9806be237328779147e28
boost/1.80.0@#a4e596ca871edb2b12bed6147041438c
boost/1.78.0@#11714360ec73dc535d9816cc300dd2af
boost/1.75.0@#e2185369012a4f9d81108ce517ee0f46
|
@randomphrase You use recipe listed in this PR and build the package locally:
Then, you can revert everything by simple running |
Signed-off-by: Uilian Ries <[email protected]>
Thanks! Confirmed working locally. |
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 (
|
Hooks produced the following warnings for commit b9f2d83boost/1.85.0@#6dbf1fdfea685c65bf3837d591774ef2
boost/1.84.0@#84d3c40fd97a5936a1a7fab3bc544ad1
boost/1.81.0@#3d0cbcb380ecfa63af718b6ac357bf82
boost/1.71.0@#89112620cd950284bec3c01635a69a64
boost/1.83.0@#e339fa4baeffc533f74549cb5534508a
boost/1.80.0@#19dfd92cb802b8c93b60ebfd5ebb20d6
boost/1.78.0@#6f2454dafa799459f9d70460a78fc24e
boost/1.75.0@#b5093d6bad501e8781e47e96ed40a22d
boost/1.82.0@#30304ccff9190928f3efb99584533dc9
boost/1.74.0@#00d69347fd61b1e1a11c8090fb5fdd10
boost/1.79.0@#13d80791b742cc5ace1e455fa0378e60
boost/1.76.0@#685ebed63c4882fd61bb835082b56650
boost/1.77.0@#e2277b951574a9e649fd2382944cf36f
boost/1.73.0@#d355209206c6fc000c62d42ec07efde6
boost/1.72.0@#8d9e48691815d3a04b5cdbd9f568b785
|
Affects boost 1.85.0 only.
Please, read #23877 and boostorg/stacktrace#163 to understand the context.
This PR does not disable the feature, but enforce the define to ignore errors.
An alternative, would be add a new option like
without_stacktrace_from_exception
and disable it when running on Mac M1/2, for instance.fixes #23877
/cc @randomphrase