Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type-checking failures #175

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix type-checking failures #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tinuous/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ def download(self, path: Path) -> list[Path]:
try:
self.client.download_zipfile(self.logs_url, path)
except requests.HTTPError as e:
if e.response.status_code in (404, 410):
if e.response is not None and e.response.status_code in (404, 410):
# 404 can happen when a workflow failed to run due to, say, a
# syntax error. 410 happens when the logs have expired.
log.error(
Expand Down
2 changes: 1 addition & 1 deletion src/tinuous/travis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def get_github_commit(self, commit_sha: str) -> Optional[Commit]:
try:
r = self.ghclient.get(f"/repos/{self.repo}/commits/{commit_sha}")
except requests.HTTPError as e:
if e.response.status_code == 404:
if e.response is not None and e.response.status_code == 404:
return None
else:
raise e
Expand Down