Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum Python version to 3.10 #33

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Increase minimum Python version to 3.10 #33

merged 2 commits into from
Nov 20, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 8, 2023

No description provided.

@jwodder jwodder added the dependencies Update one or more dependencies label Nov 8, 2023
@yarikoptic
Copy link
Member

Could we shelve this for now per #36 (comment) ?

@jwodder
Copy link
Member Author

jwodder commented Nov 10, 2023

@yarikoptic Why? Couldn't you just run solidation inside a Python 3.10 environment procured with Conda?

@yarikoptic
Copy link
Member

ok.

  • added your @jwodder ssh key to con account on smaug in case of future need for troubleshooting fixing under it
  • produced new miniconda installation with an env using 1 command: datalad-installer -E ~/miniconda3.sh miniconda --batch -c conda-fore --path ~/miniconda3 conda-env --name versations --spec python==3.10 and then just commended out that conda activate versations within ~/miniconda3.sh so we could reuse it for other ones too (attn @asmacdo -- this is an invocation I told you about in the car). I called it versations, not solidation env just reflecting current name within /mnt/datasets/con/matrix-archive/tools/.venvs/versations/bin/activate
  • did /mnt/datasets/con/matrix-archive/tools/solidation$ pip install -e .
  • did /mnt/datasets/con/matrix-archive/tools/versations$ pip install -e .

@asmacdo - do you remember if we need anything else to be done for versations for cron job to operate properly? if we are to do the switch we would need to modify those "cron" scripts we have and should be ready to accept this PR and update the state of solidation submodule there.

@asmacdo
Copy link
Member

asmacdo commented Nov 11, 2023

It could cause trouble if versations doesn't work > 3.9. I think we'll be ok, but I say lets just merge it and I'll fix versations if it doesnt work :)

@jwodder
Copy link
Member Author

jwodder commented Nov 20, 2023

@yarikoptic So is this mergeable now?

@yarikoptic
Copy link
Member

ok, I adjusted cron scripts (somehow they are not under git) to use miniconda, let's see if works or not

@yarikoptic yarikoptic merged commit b8ad616 into main Nov 20, 2023
7 checks passed
@yarikoptic yarikoptic deleted the py310 branch November 20, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants