mc_cursor finishes returning before stopping #256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this,
mc_cursor
processes would shut down after returning the last result, rather than afterreturning a final 'empty' to callers. This caused callers to try to call back for 'next()' again when
cursor was already down or going down. That call is a
gen_server:call()
. In the best case, the processwould already be down, and the call would result in a
noproc
exit, which this code catches andtranslates into a return value of 'error', instead of the correct
{}
value. In rare cases, though,due to
gen_server
code, the call would occur at the moment the process terminates, and you'll getan
exit(normal)
on the calling process instead.