Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simpleststore and local pages fixes #335

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

miki-totefu
Copy link
Collaborator

No description provided.

@karamble
Copy link

Ok. The addToCart works now for a user that uses /pages local
You can change quantities and add products to your cart.
When placing your order you receive a lnpay:// invoice

Further Suggestions:

Make the /ln payinvoice command understand the lnpay:// prefix when copy pasting it to pay the invoice.

The output message when placing an order looks good!
It has a list of ordered items, price in USD, the total amount and the exchange rate for the total sum of expected DCR to pay. It mentions the validity of the invoice for 1 hour. This message should be shown in the dialog window of the store, not only in the logfile (/w 0)

If the expected total amount to pay exceeds inbound capacity the [ERR] SSTR: message should also be displayed to the dialog window of the store and not only in the logfile (/w 0). The dialog window in the store shows "order completed!" instead, which is misleading.

@miki-totefu
Copy link
Collaborator Author

did the first 2 things

the last one is useless, because the user can't do anything about the store having no inbound capacity. i changed it to generate an onchain addr when generating the ln invoice fails

@alexlyp alexlyp merged commit d38ff35 into companyzero:master Sep 11, 2023
5 checks passed
@miki-totefu miki-totefu deleted the simplestorelocalform branch September 19, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants