Batching support #54
Open
Batching support #54
+318
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests and relevant fixes to batch projector added after update callback test Update dependencies docs temporary commanded version Skip over partial seen batch remove elixir_uuid after rebase Return error on partially seen batch again
|
Note: review can wait until Calmwave has dogfooded this for a bit. |
drteeth
requested changes
Nov 29, 2024
There was a problem hiding this comment.
Thanks for the work on this feature. It looks great, well done.
As this PR relies on upstream changes to Commanded, it will have to wait until that work is merged. See commanded/commanded#569
Before calling the PR done, the reference to the calmwave fork would need to be dropped of course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjuction commanded/commanded#569 adds support for batching Ecto projections.