-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: finish CarDocs migration to opendbc #1333
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
6a308b9
move CARS_template.md
jyoung8607 f2c3163
move docs.py, rename to generate_docs.py
jyoung8607 a34e354
move docs_definitions.py
jyoung8607 bb463f8
move test_platform_configs.py
jyoung8607 16df0a2
move test_docs.py
jyoung8607 8961b57
rename docs_definitions -> definitions
jyoung8607 b7a4a3b
rename test_docs -> test_docs_format
jyoung8607 9d6f65a
move openpilot test_docs, rename test_docs_diff
jyoung8607 cf00a08
Revert "move openpilot test_docs, rename test_docs_diff"
jyoung8607 ad50d7a
reintegrate generate_docs.py into one file
jyoung8607 cb6f975
move dump_car_docs and print_docs_diff
jyoung8607 7dbcbda
fixup imports
jyoung8607 9a091e0
fixup imports
jyoung8607 12784e0
deal with BASEDIR later
jyoung8607 c1bef26
we will, in fact, be dealing with BASEDIR now
jyoung8607 d3bb3d3
better BASEDIR
jyoung8607 6aa845c
Merge branch 'master' of https://github.com/commaai/opendbc into doc-…
jyoung8607 1d5f0c5
these go away soon, leave in openpilot
jyoung8607 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
{% set footnote_tag = '[<sup>{}</sup>](#footnotes)' %} | ||
{% set star_icon = '[![star](assets/icon-star-{}.svg)](##)' %} | ||
{% set video_icon = '<a href="{}" target="_blank"><img height="18px" src="assets/icon-youtube.svg"></img></a>' %} | ||
{# Force hardware column wider by using a blank image with max width. #} | ||
{% set width_tag = '<a href="##"><img width=2000></a>%s<br> ' %} | ||
{% set hardware_col_name = 'Hardware Needed' %} | ||
{% set wide_hardware_col_name = width_tag|format(hardware_col_name) -%} | ||
|
||
<!--- AUTOGENERATED FROM selfdrive/car/CARS_template.md, DO NOT EDIT. ---> | ||
|
||
# Supported Cars | ||
|
||
A supported vehicle is one that just works when you install a comma device. All supported cars provide a better experience than any stock system. Supported vehicles reference the US market unless otherwise specified. | ||
|
||
# {{all_car_docs | length}} Supported Cars | ||
|
||
|{{Column | map(attribute='value') | join('|') | replace(hardware_col_name, wide_hardware_col_name)}}| | ||
|---|---|---|{% for _ in range((Column | length) - 3) %}{{':---:|'}}{% endfor +%} | ||
{% for car_docs in all_car_docs %} | ||
|{% for column in Column %}{{car_docs.get_column(column, star_icon, video_icon, footnote_tag)}}|{% endfor %} | ||
|
||
{% endfor %} | ||
|
||
### Footnotes | ||
{% for footnote in footnotes %} | ||
<sup>{{loop.index}}</sup>{{footnote}} <br /> | ||
{% endfor %} | ||
|
||
## Community Maintained Cars | ||
Although they're not upstream, the community has openpilot running on other makes and models. See the 'Community Supported Models' section of each make [on our wiki](https://wiki.comma.ai/). | ||
|
||
# Don't see your car here? | ||
|
||
**openpilot can support many more cars than it currently does.** There are a few reasons your car may not be supported. | ||
If your car doesn't fit into any of the incompatibility criteria here, then there's a good chance it can be supported! We're adding support for new cars all the time. **We don't have a roadmap for car support**, and in fact, most car support comes from users like you! | ||
|
||
### Which cars are able to be supported? | ||
|
||
openpilot uses the existing steering, gas, and brake interfaces in your car. If your car lacks any one of these interfaces, openpilot will not be able to control the car. If your car has [ACC](https://en.wikipedia.org/wiki/Adaptive_cruise_control) and any form of [LKAS](https://en.wikipedia.org/wiki/Automated_Lane_Keeping_Systems)/[LCA](https://en.wikipedia.org/wiki/Lane_centering), then it almost certainly has these interfaces. These features generally started shipping on cars around 2016. Note that manufacturers will often make their own [marketing terms](https://en.wikipedia.org/wiki/Adaptive_cruise_control#Vehicle_models_supporting_adaptive_cruise_control) for these features, such as Hyundai's "Smart Cruise Control" branding of Adaptive Cruise Control. | ||
|
||
If your car has the following packages or features, then it's a good candidate for support. | ||
|
||
| Make | Required Package/Features | | ||
| ---- | ------------------------- | | ||
| Acura | Any car with AcuraWatch Plus will work. AcuraWatch Plus comes standard on many newer models. | | ||
| Ford | Any car with Lane Centering will likely work. | | ||
| Honda | Any car with Honda Sensing will work. Honda Sensing comes standard on many newer models. | | ||
| Subaru | Any car with EyeSight will work. EyeSight comes standard on many newer models. | | ||
| Nissan | Any car with ProPILOT will likely work. | | ||
| Toyota & Lexus | Any car that has Toyota/Lexus Safety Sense with "Lane Departure Alert with Steering Assist (LDA w/SA)" and/or "Lane Tracing Assist (LTA)" will work. Note that LDA without Steering Assist will not work. These features come standard on most newer models. | | ||
| Hyundai, Kia, & Genesis | Any car with Smart Cruise Control (SCC) and Lane Following Assist (LFA) or Lane Keeping Assist (LKAS) will work. LKAS/LFA comes standard on most newer models. Any form of SCC will work, such as NSCC. | | ||
| Chrysler, Jeep, & Ram | Any car with LaneSense and Adaptive Cruise Control will likely work. These come standard on many newer models. | | ||
|
||
### FlexRay | ||
|
||
All the cars that openpilot supports use a [CAN bus](https://en.wikipedia.org/wiki/CAN_bus) for communication between all the car's computers, however a CAN bus isn't the only way that the computers in your car can communicate. Most, if not all, vehicles from the following manufacturers use [FlexRay](https://en.wikipedia.org/wiki/FlexRay) instead of a CAN bus: **BMW, Mercedes, Audi, Land Rover, and some Volvo**. These cars may one day be supported, but we have no immediate plans to support FlexRay. | ||
|
||
### Toyota Security | ||
|
||
openpilot does not yet support these Toyota models due to a new message authentication method. | ||
[Vote](https://comma.ai/shop#toyota-security) if you'd like to see openpilot support on these models. | ||
|
||
* Toyota RAV4 Prime 2021+ | ||
* Toyota Sienna 2021+ | ||
* Toyota Venza 2021+ | ||
* Toyota Sequoia 2023+ | ||
* Toyota Tundra 2022+ | ||
* Toyota Highlander 2024+ | ||
* Toyota Corolla Cross 2022+ (only US model) | ||
* Toyota Camry 2025+ | ||
* Lexus NX 2022+ | ||
* Toyota bZ4x 2023+ | ||
* Subaru Solterra 2023+ | ||
|
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path to the out file should be in openpilot and passed in.
Since we don't write any docs in opendbc, probably best to leave everything in openpilot for now
For example, web4 just needs the opendbc API:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that.
We will. The new ALL-CARS.md (or whatever name we bikeshed) will live in opendbc. It needs to run, generate, save, and test in opendbc without having openpilot available.
CARS.md only lives in openpilot because we don't want to change the link until we have a bigger step-change in how it looks and works.
I'll see if I can juggle things to maintain that import location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just make docs.py executable and write the opendbc docs by default, then openpilot's docs.py can stay using the APIs in this file