Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port "rpc: Add HTTP timeout" (tendermint-rs#1380) #26

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Port "rpc: Add HTTP timeout" (tendermint-rs#1380) #26

merged 1 commit into from
Apr 25, 2024

Conversation

romac
Copy link
Collaborator

@romac romac commented Mar 14, 2024

Closes: #20

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@03974f5). Click here to learn what that means.

❗ Current head 65de526 differs from pull request most recent head 18b8a3b. Consider uploading reports for the commit 18b8a3b to get more accurate results

Files Patch % Lines
rpc/src/client/transport/http.rs 50.0% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main     #26   +/-   ##
======================================
  Coverage        ?   57.1%           
======================================
  Files           ?     254           
  Lines           ?   27590           
  Branches        ?       0           
======================================
  Hits            ?   15764           
  Misses          ?   11826           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romac romac merged commit 20b4428 into main Apr 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port "rpc: Add HTTP timeout" (tendermint-rs#1380)
2 participants