Improve PerformableMethod logging #1187
Open
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small logging improvement for
PerformableMethod
.This PR adds warning message when
Object#delay
is called with a block given.Use case:
The code below won't perform as intended because blocks cannot be serialized and thus a job will ignore the block.
I think it is convenient to display a warning like
Ignored the block XXX because it cannot be serialized.
when developers using the gem accidentally give block.