Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Allow for linear tree classifiers #135

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

bammari
Copy link
Collaborator

@bammari bammari commented Oct 31, 2023

This PR will allow users to utilize linear tree classifiers from the linear-tree Python library.

UPDATE: 10/31
Currently support binary classification. The OMLT model output is a number <= 0 (which corresponds to class 0) or a number >0 (which corresponds to class 1). Users can handle these outputs with additional Big-M constraints to transform the output to 0 and 1.

In Progress:

  1. Provide an option to generate these Big-M constraints for the user.
  2. Testing, documentation, and examples
  3. Multiclass models

Legal Acknowledgement
By contributing to this software project, I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license.
If my employer has rights to intellectual property that includes these contributions,
I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (b9600e2) 95.95% compared to head (f2cd74c) 94.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   95.95%   94.87%   -1.08%     
==========================================
  Files          29       29              
  Lines        1656     1678      +22     
  Branches      255      262       +7     
==========================================
+ Hits         1589     1592       +3     
- Misses         35       51      +16     
- Partials       32       35       +3     
Files Coverage Δ
src/omlt/linear_tree/lt_definition.py 88.00% <24.00%> (-10.70%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant