fixed Caret.isAtStart #2448
Open
fixed Caret.isAtStart #2448
+54
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VKR981
requested review from
neSpecc,
gohabereg,
TatianaFomina and
ilyamore88
as code owners
ilyamore88
requested changes
Aug 20, 2023
src/components/modules/caret.ts
Outdated
| @@ -120,7 +109,7 @@ export default class Caret extends Module { | |||
| return $.isEmpty(node) && !isLineBreak; | |||
| }); | |||
|
|
|||
| if (nothingAtLeft && focusOffset === firstLetterPosition) { | |||
| if (nothingAtLeft && focusOffset===0) { | |||
There was a problem hiding this comment.
Hi, I have added the test cases can you please review them? also I'm new to open source and TDD.
|
Hey, can someone merge this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current Caret.isAtStart ignores white spaces causing this issue
#2429