Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: v1 to v2 upgrade guide #259

Merged
merged 6 commits into from
Nov 26, 2024
Merged

docs: v1 to v2 upgrade guide #259

merged 6 commits into from
Nov 26, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented Jul 4, 2024

Adds the upgrade guide for v1 to v2.

I could not find an easier way to preview and test the guide, but it should look like the recording below.
courtesy: https://registry.terraform.io/tools/doc-preview

Screen.Recording.2024-11-21.at.6.33.00.PM.mov

@matifali matifali changed the title wip: wip: v1 to v2 migration guide Jul 4, 2024
@matifali matifali closed this Jul 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
@matifali matifali reopened this Nov 20, 2024
@matifali matifali self-assigned this Nov 20, 2024
@coder coder unlocked this conversation Nov 20, 2024
@matifali matifali marked this pull request as ready for review November 21, 2024 07:45
@matifali matifali changed the title wip: v1 to v2 migration guide docs: v1 to v2 migration guide Nov 21, 2024
@matifali matifali marked this pull request as draft November 21, 2024 12:35
@matifali matifali force-pushed the matifali/migration-guide branch 2 times, most recently from 601b056 to cd46d6d Compare November 21, 2024 13:19
@matifali matifali changed the title docs: v1 to v2 migration guide docs: v1 to v2 upgrade guide Nov 21, 2024
@matifali matifali marked this pull request as ready for review November 21, 2024 13:22
go.mod Show resolved Hide resolved
@@ -8,7 +8,11 @@ description: |-

# Coder Provider

Terraform provider for managing Coder [templates](https://coder.com/docs/templates), which are the underlying infrastructure for Coder [workspaces](https://coder.com/docs/workspaces).
Terraform provider for managing Coder [templates](https://coder.com/docs/admin/templates), which are the underlying infrastructure for Coder [workspaces](https://coder.com/docs/user-guides/workspace-management).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links could be updated when we have a Glossary of terms.

docs/index.md Outdated Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.


## Provider Arguments

Version 2.0.0 removes the [`feature_use_managed_variables`](https://registry.terraform.io/providers/coder/coder/1.0.4/docs#feature_use_managed_variables-1) argument from the `provider` block.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should explain that this has been deprecated for a long time and has no impact on Coder workspace anymore.

Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM!

@matifali matifali added the docs Improvements or additions to documentation label Nov 21, 2024
docs/guides/version-2-upgrade.md Outdated Show resolved Hide resolved
docs/guides/version-2-upgrade.md Outdated Show resolved Hide resolved
docs/guides/version-2-upgrade.md Outdated Show resolved Hide resolved
docs/guides/version-2-upgrade.md Outdated Show resolved Hide resolved
@matifali matifali merged commit 0fc1112 into main Nov 26, 2024
8 checks passed
@matifali matifali deleted the matifali/migration-guide branch November 26, 2024 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants