Support environment variables defined in containerEnv #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Mar 2, 2024
envbuilder only looked at remoteEnv, but it should also define variables from containerEnv. containerEnv is recommended over remoteEnv by the spec: > We recommend using containerEnv (over remoteEnv) as much as possible > since it allows all processes to see the variable and isn’t > client-specific.
aaronlehmann
force-pushed
the
support-containerenv
branch
from
472990e
to
bfab4c8
Compare
|
@kylecarbs: Updated to fix the test. Does GitHub no longer run CI on PRs for this repo, or is there some manual step needed? |
|
Weird, CI ran on this PR: #95 |
|
It must be because this PR comes from my fork and the other one doesn't. |
|
cc @coryb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envbuilder only looked at
remoteEnv, but it should also define variables fromcontainerEnv.containerEnvis recommended overremoteEnvby the spec: