-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated website view tests #78
base: master
Are you sure you want to change the base?
updated website view tests #78
Conversation
Run tests with 'python manage.py test' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the test case for test_form_data_view_scheduled
fails now because I believe the case's arraignment date is in the past and as such cannot be setup for reminder. Can you choose a different case number?
I can, or I can implement some mocking so we don't have to rely on actual case data, which changes. |
Actually, I'm not sure how to mock a request made within another request. I can just change the case number for now. |
The trick to mocking calls from inside another request is to mock it with the full context from where it is being called: e.g.
hope this helps. |
Awesome, thanks jdungan. I'll get to work on that and commit again |
I updated the website views test cases with the changed post endpoint name, different phone numbers, and updated success message.