Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: stats, encoding: improve UUID-decoding error #136036

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 22, 2024

Backport 1/1 commits from #136015 on behalf of @michae2.

/cc @cockroachdb/release


Add a length check to DecodeUUIDValue and a more informative error wrapping to DecodeUpperBound, which will hopefully help us track down the cause of #128876.

The wrapped error message looks like:

decoding histogram version 3 type uuid value ‹666f6f›: invalid uuid length of 2

Informs: #128876

Epic: None

Release note: None


Release justification: low-risk debugging for error.

Add a length check to `DecodeUUIDValue` and a more informative error
wrapping to `DecodeUpperBound`, which will hopefully help us track down
the cause of #128876.

The wrapped error message looks like:

```
decoding histogram version 3 type uuid value ‹666f6f›: invalid uuid length of 2
```

Informs: #128876

Epic: None

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.2-136015 branch from b51f8ba to 330810d Compare November 22, 2024 21:47
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 22, 2024 21:47
@blathers-crl blathers-crl bot removed the request for review from a team November 22, 2024 21:47
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 22, 2024
@blathers-crl blathers-crl bot requested a review from michae2 November 22, 2024 21:47
Copy link
Author

blathers-crl bot commented Nov 22, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 22, 2024
@blathers-crl blathers-crl bot requested a review from a team November 22, 2024 21:47
Copy link
Author

blathers-crl bot commented Nov 22, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @michae2, @mw5h, and @rytaft)

@michae2 michae2 merged commit cff66e2 into release-24.2 Nov 23, 2024
19 of 20 checks passed
@michae2 michae2 deleted the blathers/backport-release-24.2-136015 branch November 23, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants