-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support excluded sync resources #617
Open
KubeKyrie
wants to merge
1
commit into
clusterpedia-io:main
Choose a base branch
from
KubeKyrie:feat-excluded-sync-resources
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: support excluded sync resources #617
KubeKyrie
wants to merge
1
commit into
clusterpedia-io:main
from
KubeKyrie:feat-excluded-sync-resources
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @KubeKyrie, DetailsInstructions for interacting with me using comments are available here. |
KubeKyrie
force-pushed
the
feat-excluded-sync-resources
branch
5 times, most recently
from
December 14, 2023 10:10
b83f1d1
to
cf36967
Compare
KubeKyrie
force-pushed
the
feat-excluded-sync-resources
branch
from
December 28, 2023 16:21
cf36967
to
c842190
Compare
KubeKyrie
force-pushed
the
feat-excluded-sync-resources
branch
2 times, most recently
from
December 29, 2023 08:45
313a7a4
to
cdef1d8
Compare
Signed-off-by: KubeKyrie <[email protected]>
KubeKyrie
force-pushed
the
feat-excluded-sync-resources
branch
from
January 2, 2024 15:28
cdef1d8
to
139a875
Compare
@Iceber PTAL, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #611
Special notes for your reviewer:
Add excludeResources for syncResources of pediacluster and clustersyncresources.
And excludeResources is optional.
New yaml just like:
Does this PR introduce a user-facing change?: