[ui-core]: feat: add useLoadData hook for API calls #3819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramprasadagarwal
requested review from
tabraiz12,
bjornalm,
Harshg999 and
nidhibhatg
ramprasadagarwal
changed the title
tabraiz12
reviewed
Aug 19, 2024
| const response = await get<T, U>(fetchUrl, localOptions?.params, fetchOptions); | ||
| setData(response); | ||
| } catch (error) { | ||
| setError(error); |
There was a problem hiding this comment.
Make sure that we're setting an Error object. As the type set is Error
setError(error instanceof Error ? error : new Error(error);
tabraiz12
approved these changes
Aug 19, 2024
bjornalm
approved these changes
Aug 20, 2024
| import { useCallback, useEffect, useMemo, useState } from 'react'; | ||
| import { ApiFetchOptions, get } from '../../api/utils'; | ||
|
|
||
| export type IOptions<T, U> = { |
There was a problem hiding this comment.
What is the purpose of the I-prefix? If it is to indicate an interface, perhaps it would better to use an interface instead of type.
| const [loading, setLoading] = useState<boolean>(false); | ||
| const [error, setError] = useState<Error | undefined>(); | ||
|
|
||
| const fetchOptionsDefault: ApiFetchOptions<T> = { |
There was a problem hiding this comment.
nit: this could be defined outside the component
| reloadData: () => void; | ||
| }; | ||
|
|
||
| const useLoadData = <T, U = unknown>(url?: string, options?: IOptions<T, U>): IUseLoadData<T> => { |
There was a problem hiding this comment.
what is the use case for not passing in a url?
ramprasadagarwal
added a commit
that referenced
this pull request
Aug 20, 2024
* [ui-core]: feat: add useFetch hook for API calls * add the license information * fix lint * lint fix * add library * pin the library version * revert extra changes * revert package-lock json * fix: rename hook * fix the function name * typecaste error object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
useLoadDatareact hook which exposes thedata,loading,error, andrefetchto the react component.How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.