Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add documentation for new file browser public APIs #3759

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

Harshg999
Copy link
Collaborator

What changes were proposed in this pull request?

  • Added docs section for all new filebrowser APIs

How was this patch tested?

  • Manually

Copy link
Collaborator

@pychheda pychheda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have provided my feedback. Please review. Thanks.

docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ananya-agarwal ananya-agarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..Apart from the documentation lints needs fixing.

Copy link
Collaborator

@pychheda pychheda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few more comments.

docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, butI think we can be a bit more specific

docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
@Harshg999 Harshg999 disabled auto-merge June 24, 2024 13:31
@Harshg999
Copy link
Collaborator Author

Thank you @pychheda and @bjornalm for your detailed review! I've incorporated the suggestions and rephrased most of the lines.

Can you please review again to see if I'm are missing anything? Thanks!

Copy link
Collaborator

@pychheda pychheda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased sentences to use active voice, for better clarity.
The rest looks good.

docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
docs/docs-site/content/developer/api/rest/_index.md Outdated Show resolved Hide resolved
@Harshg999 Harshg999 requested a review from pychheda June 25, 2024 07:12
Copy link
Collaborator

@pychheda pychheda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for promptly incorporating the feedback.

@Harshg999 Harshg999 enabled auto-merge (squash) June 25, 2024 07:15
@Harshg999 Harshg999 merged commit d34fd43 into master Jun 25, 2024
4 of 5 checks passed
@Harshg999 Harshg999 deleted the Harshg999-patch-3 branch June 25, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants