[ui-storageBrowser]Handle errors and improvements

cloudera · Jun 14, 2024 · a197aed · a197aed
1 parent 1bd4d52
commit a197aed
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/...js/apps/storageBrowser/StorageBrowserPage/StorageBrowserActions/StorageBrowserActions.tsx b/...js/apps/storageBrowser/StorageBrowserPage/StorageBrowserActions/StorageBrowserActions.tsx
@@ -41,10 +41,11 @@ const StorageBrowserActions = ({ selectedFiles }: StorageBrowserRowActionsProps)
   const { t } = i18nReact.useTranslation();
 
   const isSummaryEnabled = () => {
+    const selectedFile = selectedFiles[0];
     return (
       selectedFiles.length == 1 &&
-      (isHDFS(selectedFiles[0].path) || isOFS(selectedFiles[0].path)) &&
-      selectedFiles[0].type === 'file'
+      (isHDFS(selectedFile.path) || isOFS(selectedFile.path)) &&
+      selectedFile.type === 'file'
     );
   };
 
@@ -74,8 +75,8 @@ const StorageBrowserActions = ({ selectedFiles }: StorageBrowserRowActionsProps)
         }}
         trigger={['click', 'hover']}
       >
-        <Button onClick={e => e.stopPropagation()} data-event="">
-          Actions
+        <Button data-event="">
+          {t('Actions')}
           <DropDownIcon />
         </Button>
       </Dropdown>

diff --git a/...top/js/apps/storageBrowser/StorageBrowserPage/StorageBrowserTable/StorageBrowserTable.tsx b/...top/js/apps/storageBrowser/StorageBrowserPage/StorageBrowserTable/StorageBrowserTable.tsx
@@ -32,6 +32,7 @@ import { PrimaryButton } from 'cuix/dist/components/Button';
 import Table from 'cuix/dist/components/Table';
 
 import { i18nReact } from '../../../../utils/i18nReact';
+import huePubSub from '../../../../utils/huePubSub';
 import { mkdir, touch } from '../../../../reactComponents/FileChooser/api';
 import {
   PageStats,
@@ -226,8 +227,8 @@ const StorageBrowserTable = ({
         setRefreshKey(oldKey => oldKey + 1);
       })
       .catch(error => {
-        // eslint-disable-next-line no-restricted-syntax
-        console.log(error);
+        huePubSub.publish('hue.error', error);
+        setShowNewFolderModal(false);
       })
       .finally(() => {
         setLoadingFiles(false);
@@ -241,8 +242,8 @@ const StorageBrowserTable = ({
         setRefreshKey(oldKey => oldKey + 1);
       })
       .catch(error => {
-        // eslint-disable-next-line no-restricted-syntax
-        console.log(error);
+        huePubSub.publish('hue.error', error);
+        setShowNewFileModal(false);
       })
       .finally(() => {
         setLoadingFiles(false);