INI opcode updates. More unit tests. #225
Merged
+235
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiranDMC
force-pushed
the
INI_opcode_updates
branch
from
8dc55bd
to
42c60f7
Compare
MiranDMC
force-pushed
the
INI_opcode_updates
branch
from
42c60f7
to
ae22d21
Compare
x87
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests updated to reflect way GetPrivateProfileInt/Float APIs work (read number characters until error).
Fixed reporting success when reading numbers from fields not containing number at all.
Fixed success result when filepath targets directory.
Fixed read int opcode returning value
0x80000000on error. (kept in legacy mode)Fixed read int opcode reporting fail if value in file was
0x80000000All INI unit tests passing now.