Flashing of debug break message. #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x87
reviewed
Sep 30, 2024
| @@ -97,7 +97,8 @@ class DebugUtils | |||
| screenLog.Draw(); | |||
|
|
|||
| // draw active breakpoints list | |||
| if(!pausedScripts.empty()) | |||
| if (!pausedScripts.empty() && | |||
| (CTimer::m_FrameCounter & 0xE) != 0) // flashing | |||
There was a problem hiding this comment.
can it be distracting/annoying?
should we consider an option to toggle it?
There was a problem hiding this comment.
Everything is frozen, there is not much to be distracted from. I caught myself several times on thinking game just crashed.
Flashing is more like text disappearing for every 16th frame, so it draws attention but still is readable.
Only active break point list on the right side of the screen is flashing.
x87
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make script break point message flashing, so it does not look like game froze.