Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lodash-es with es-toolkit #17496

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented Nov 20, 2024

Suggested merge commit message (convention)

Other: Replace lodash-es with es-toolkit.


You can find more information about why we make this change here: #16395 (comment)

Below are the files that still use lodash-es because es-toolkit doesn't yet have support for extend and cloneDeepWith:

  • extend in engine/src/view/observer/domeventdata.ts
  • extend in ui/src/model.ts
  • cloneDeepWith in ui/src/template.ts
  • cloneDeepWith in utils/src/config.ts
  • cloneDeepWith in watchdog/src/editorwatchdog.ts

@Witoso
Copy link
Member

Witoso commented Nov 20, 2024

TBH, this is the first time I heard we keep lodash... I thought it's 1:1 replacement, and having two libs makes less sense for me.

R- from me, as it's increasing dependencies count w/o discussing this openly. And what are potential workarounds for this.

@filipsobol
Copy link
Member Author

We've decided to put this on hold until extend and cloneDeepWith are available in es-toolkit.

I'll also contribute to the isElement implementation because it cannot be replaced with simple instanceof HTMLElement in our case (as I did in the PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants