PG17 compatibility: fix multi-1 diffs caused by PG17 optimizer enhancements #7769
+35
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colm-mchugh
force-pushed
the
cmchugh/pg17-multi-1-query-adjustments
branch
from
2d0e9ae
to
41b873f
Compare
43 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## naisila/pg17_support #7769 +/- ##
========================================================
- Coverage 89.62% 89.61% -0.01%
========================================================
Files 274 274
Lines 59689 59689
Branches 7446 7446
========================================================
- Hits 53495 53492 -3
Misses 4065 4065
- Partials 2129 2132 +3 |
multi_router_planner_fast_path and query_single_shard_table Restore the expected DEBUG error messages from the router planner. In the case of query_single_shard_table the diffs are because of PG17's ability to pull up correlated ANY subqueries (*). The fix is to inhibit pull up with a volatile function. In the case of multi_router_planner and multi_router_planner_fast_path the diffs are because of PG17's ability to remove redundant IS (NOT) NULL expressions (**). The fix is to adjust the table definition so the column used for distribution is not marked NOT NULL. (*) https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=9f1337639 (**) https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=b262ad440
colm-mchugh
force-pushed
the
cmchugh/pg17-multi-1-query-adjustments
branch
from
41b873f
to
0ec4a68
Compare
colm-mchugh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix restores the expected DEBUG error messages from the router planner in
multi_router_planner,multi_router_planner_fast_pathandquery_single_shard_table. In the case ofquery_single_shard_tablethe diffs are because of this PG17 commit, which enables the optimizer to pull up a correlated ANY subquery to a join. The fix inhibits subquery pull up by including a volatile function in the predicate involving the ANY subquery.In the case of
multi_router_plannerandmulti_router_planner_fast_paththe diffs are because of this PG17 commit, which enables the optimizer to detect and remove redundant IS (NOT) NULL expressions. The fix is to adjust the table definition so the column used for distribution is not marked NOT NULL, thus preserving .Finallly, the DEBUG logging level is lowered for CREATE MATERIALIZED VIEW AS statements in
multi_router_plannerandmulti_router_planner_fast_pathbecause of this PG17 commit; when creating materialized views, use REFRESH logic to load data. A consequence of this is that withclient_min_messagesatDEBUG2the following is emitted for CREATE MATERIALIZED VIEW AS statements:drop auto-cascades to type multi_router_planner.pg_temp_42245. This is part of the REFRESH logic, and also relevant is this PG17 commit which sets the search_path to 'pg_catalog, pg_temp' during maintenance operations (including REFRESH MATERIALIZED VIEW)