PG17 regress sanity: fix error unrecognized alter database option tablespace seen in database vanilla test #7764
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-13.0 #7764 +/- ##
===============================================
Coverage ? 89.59%
===============================================
Files ? 274
Lines ? 59584
Branches ? 7436
===============================================
Hits ? 53387
Misses ? 4052
Partials ? 2145 |
colm-mchugh
changed the title
naisila
approved these changes
Nov 22, 2024
This was referenced Nov 22, 2024
all Postgres DDL commands to compelte without being propagated by Citus.
colm-mchugh
force-pushed
the
7763-fix-error-unrecognized-alter-database-option-tablespace-seen-in-database-vanilla-test
branch
from
1d338b6
to
1cc62a2
Compare
colm-mchugh
deleted the
7763-fix-error-unrecognized-alter-database-option-tablespace-seen-in-database-vanilla-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable DDL propagation for the vanilla test suite. This enables the vanilla
databasetest to pass, where previously it was correctly returningERROR: unrecognized ALTER DATABASE option: tablespacebecause release-13.0 does not propagate this ALTER DATABASE variant.We (Citus team) discussed cherry picking #7253 from main to release-13.0 because it does propagate ALTER DATABASE tablespace option (as well as a couple of others) but decided fixing the regress test was not the proper context for that. The fix disables
citus.enable_metadata_syncwhen running vanilla, we discussed disablingcitus.enable_create_database_propagationbut this is not in release-13.0.