-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(images): use github/repo as hosting #1125
base: master
Are you sure you want to change the base?
Conversation
Images are now hosted with GitHub and pages use their relative URLs. These pages all seem to be about csharp. Not sure how to fix for the other languages.
While I see the big effort, I think just inserting images instead of I also think that type of structure is fine since it's easy for anyone to change it. Maybe change the images name with a "standart" for people that will contribute in the future to follow. I would recommand maybe image description (short version). E.g. for SetCamSplineSmoothingStyle it would be Anyways that's just my personnal opinion, good job :) |
I have previewed every page in vscode's markdown preview extension. Thus why I made some adjustments to the formatting, so images actually display and use the next line for rendering.
It would be fine to rename them at this point, since I already took the time to do all this. But I would like for this to be reviewed first, before doing further work. Maybe @AvarianKnight could review? |
Vscode preview vs actual docs UI are not the same. You can build in localhost. For the rest, before doing a big work like this it's always better to ask. Based on @4mmonium comment here (like you know), they are working in a solution wich not might be Github. And for the code it-self, tweaks might need to be do for the correct format and size on every image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure on what the status is of getting image links back, but this is a decent stop gap for now, and if needed can be reverted whenever the cdn stuff gets sorted out by Cfx.
Apologies for the time taken to correct this. I have corrected the referenced files @AvarianKnight |
Going to mark this as a draft for now, we're discussing on how this should be handled. |
Images are now hosted with GitHub and pages use their relative URLs.
Not sure if this structure would be acceptable, but am open to suggestions.