feat(extra-natives/five): visual settings getter native #2951
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniGP17
reviewed
Nov 20, 2024
code/components/extra-natives-five/src/VisualSettingsNatives.cpp
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
New native for getting the values from visualsettings.dat. There existed a setter to tune them via script, but there was no getter.
...
How is this PR achieving the goal
Create a new native which allows getting the floating point value of a specific visualsettings.dat setting.
...
This PR applies to the following area(s)
FiveM
...
Successfully tested on
Game builds: 3095, 3258
Platforms: Windows ( client )
Checklist