Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use -Werror #3809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not use -Werror #3809

wants to merge 1 commit into from

Conversation

ryandesign
Copy link

Using -Werror can cause builds to fail when using unexpected compilers.

For example: https://trac.macports.org/ticket/71354

By all means, manually add -Werror to your CI if you want to ensure warning-free builds using compilers you're testing, but don't force it on your users and make their builds fail just because they're using a compiler that has a warning you didn't anticipate.

Using -Werror can cause builds to fail when using unexpected compilers.
@@ -41,7 +41,6 @@ cpu_family = host_machine.cpu_family()

supported_arguments = cpp.get_supported_arguments([
'-Wno-non-virtual-dtor',
'-Werror',
'-Wunused-but-set-variable',
'-Wno-strict-aliasing'])

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sees

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants