2594 design review - [HOTGOV] #3066

asaki222 · 2024-11-12T20:04:08Z

Ticket

Resolves #2594

Changes

Domain Request Confirmation Changes

On the confirmation page of domain request, changed the sentence "You can check the status of your request at any time on the registrar page" to "You can check the status of your request at any time on the registrar".
The link on the status of the above text on "status" points to the requests page.
The text adjusted top padding to 32px instead of 24px.

Domain Requests Page Changes

Reduced spacing between h1 and p to 8px instead of 16px.
Narrowed the width of p under h1 so that it never expands pass 320px.

Domain Request Flow

Navigation bar(Domains/Domain Requests/Members) now appears when entering the flow
Header and Nav Bars now have a widescreen version that are in the domain and domain request pages.

Text Changes: No access to domain request page and No access to domains page

"access to a request" to "access to requests"
"Your organizations administrators:" changed to "Your organization's administrators"
"Current domain requests" to "Domain Requests"

Withdraw a Domain Request Page and Confirmation Page

Wrapper padding top changed from 24px to 48px

Requesting Entity Page

made the text that says "Department of Energy" dynamic to display fed agency or organization name
Updated "used by the"=> "used by"

Requesting entity page > add suborganization

Updated the second sentence in the intro paragraph to read: "If you don’t see your suborganization in the list, select “other.”
In the dropdown, change "organization" to "suborganization"
The link to ".gov public data" opens into a new tab
"select other" changed to " select “other.""

Requesting entity page > add suborganization > error messages

The error messages updated to the following:

Enter the name of your suborganization.
Enter the city where your suborganization is located.
Select the state, territory, or military post where your suborganization is located.
The suborganization dropdown and the requested suborganization box has an updated margin from 8px to 24px.

Context for reviewers

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Met the acceptance criteria, or will meet them in a subsequent PR
Created/modified automated tests
Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Pulled this branch locally and tested it
Verified code meets all checks above. Address any checks that are not satisfied
Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
Checked that all code is adequately covered by tests
Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
(Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

Checked that the design translated visually
Checked behavior. Comment any found issues or broken flows.
Checked different states (empty, one, some, error)
Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
- Chrome
- Microsoft Edge
- FireFox
- Safari
(Rarely needed) Tested as both an analyst and applicant user

References

Code review best practices

Screenshots

….get.gov into backup/2594-design-review

…ion bar

… backup/2594-design-review

github-actions · 2024-11-12T20:20:49Z