Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Review: Domain Request pages #2594

Closed
4 tasks
abroddrick opened this issue Aug 15, 2024 · 5 comments · Fixed by #3066
Closed
4 tasks

Design Review: Domain Request pages #2594

abroddrick opened this issue Aug 15, 2024 · 5 comments · Fixed by #3066
Assignees
Labels
carryover Carryover from a previous sprint design design-review Needs design review dev Feature: 🏢 Org Model

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Aug 15, 2024

Issue description

Design should review and compare the output for the domain request pages and compare against the most recent figma and requirements.

In scope:

  • Domain Request table
  • Navigation
  • All domain request pages visible to users
  • Request form

Out of scope:

  • Django Admin
  • Other areas not related to domain request flow

Acceptance criteria

  • Design reviews the domain request pages described above
  • Document any changes needed or new additions in a document, including with screenshots so it is easy to follow
  • Discuss changes with dev and determine which are small email to be done as part of this ticket
  • Work with dev to create new tickets for larger changes

Additional context

Working with dev: Dev effort on this shouldn't be more than a "2" (2 full work days).

  • Dev is responsible for answering questions from design, making minor changes (such as those that we would normally make on a PR).
  • Anything that would take more than 4 hours to complete alone should be it's own ticket.
  • If the amount of changes desired would result in the dev spending more than a full day on it, make a dev ticket for items where reasonable (communicate with Alysia).

NOTE: This design review does not include sending/testing email notifications to domain requesters. That will be tested separately once that work is implemented.

Temporary Slack channel

Discussions for this design review should take place in this Slack channel: 2594-design-review

Links to other issues

-blocked by #2760

Copy link

cc/ @Katherine-Osos — adding you to this design-review issue!

@katypies
Copy link
Contributor

I don't see why this is blocked by the ability to export reports. Can you help clarify, @abroddrick ?

@katypies katypies moved this from 👶 New to 🍦 Backlog in .gov Product Board Aug 22, 2024
@abroddrick abroddrick moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Sep 24, 2024
@abroddrick
Copy link
Contributor Author

@katypies The only reason it was marked as blocked by the csv is because it is in the milestone. I am not opposed to us doing this review and then reviewing the csv separately. I'll let @Katherine-Osos and @witha-c have final say

@Katherine-Osos
Copy link
Contributor

Agree, this shouldn't be blocked by csv downloads!

@vickyszuchin
Copy link

Moved all "In progress" sprint 57 tickets to the current sprint (sprint 58), per guidance.

@asaki222 asaki222 moved this from 🏗 In progress to ✅ Done in .gov Product Board Nov 14, 2024
@asaki222 asaki222 closed this as completed by moving to ✅ Done in .gov Product Board Nov 14, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🚗 Parking Lot in .gov Product Board Nov 19, 2024
@zandercymatics zandercymatics moved this from 🚗 Parking Lot to 👀 In review in .gov Product Board Nov 19, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in .gov Product Board Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment