Ignore empty lockfiles #555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty lockfile could appear in case of panic, reboot/power cycle shortly after VM start command. In such cases lockfile's metadata might have been already synced to disk, but the file contents itself is not. After reboot, this results in an empty lock file, which prevents VM from start; as hostname stored in such lockfile (nothing/empty string) doesn't match to hostname.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty lockfile could appear in case of panic, unexpected reboot/power cycle shortly after VM start command.
In such cases, lockfile's metadata might have been already synced to disk, but the file contents itself is not.
After reboot, this results in an empty lock file, which prevents VM from start; as hostname stored in such lockfile (nothing/empty string) doesn't match to hostname.