Split World and Dimension into their own classes #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
World handles per-world data, and loading Dimensions Dimension handles regions, chunks, loading chunks, and any per-dimension data. This commit fails to run without commenting out all of the CubicChunks classes
|
This PR has some reasonable change of breaking plugin api actually |
leMaik
approved these changes
Aug 4, 2023
NotStirred
force-pushed
the
feature/world_dimensions
branch
from
3d2369b
to
464dfd2
Compare
|
(force push to drop redundant plugin api commit) |
leMaik
pushed a commit
to leMaik/chunky
that referenced
this pull request
Sep 9, 2023
* Split the concepts of Dimension and World into their own class. World handles per-world data, and loading Dimensions Dimension handles regions, chunks, loading chunks, and any per-dimension data. This commit fails to run without commenting out all of the CubicChunks classes * Properly handle loading cubic dimensions * Don't reload world when switching dimensions, only load the new dimension * Correct following project naming conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the concepts of Dimension and World into their own class,
World handles per-world data, and loading Dimensions
Dimension handles regions, chunks, loading chunks, and any per-dimension data.
There is no API for detecting the format of a world or dimensions within it, hopefully that can come in the next PR
This PR properly loads a world with one or more vanilla dimensions, and one or more CubicChunks dimensions (previously the entire world was either vanilla or CubicChunks)