Refactor RenderConfig interface #1561
Conversation
…g term goal is to reduce the amount of context which is pushed around for rendering with the RenderManager/RenderContext) TODO later: split SceneIOProvider from RenderContext
TODO: add PluginAPI
ShirleyNekoDev
force-pushed
the
refactor/render-config
branch
from
abd7168
to
471416f
Compare
| protected void startRender(Renderer renderer) throws InterruptedException { | ||
| renderer.render(this); | ||
| } |
There was a problem hiding this comment.
I believe I added this to be overridable by custom RenderManagers to add pre-start logic.
There was a problem hiding this comment.
e.g. setting data in the new worker state / ray factories
| @@ -0,0 +1,40 @@ | |||
| package se.llbit.chunky.renderer; | |||
|
|
|||
| public class ModifiableRenderOptions implements RenderOptions { | |||
There was a problem hiding this comment.
See above. Can we improve this so that modifying the render options is safe and gets applied after the user confirms (or reset otherwise)?
There was a problem hiding this comment.
Pretty sure that this would be the job of the UI logic or something in the render code which copies its state from this object. At the moment, the user can only set the tile size and spp per pass via CMD argument, right? And render thread count had some special handling somewhere which already required restarting the rendering or Chunky (?). Definitively a useful suggestion for a follow-up issue + PR :)
(long term goal is to reduce the amount of context which is pushed around for rendering with the RenderManager/RenderContext)