Extract canvas size code from Scene into separate CanvasConfig class #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShirleyNekoDev
force-pushed
the
refactor/canvas-size
branch
from
9b6e83e
to
4288a6a
Compare
NotStirred
approved these changes
Mar 6, 2023
leMaik
reviewed
Mar 12, 2023
chunky/src/java/se/llbit/chunky/renderer/scene/CanvasConfig.java
Outdated
Show resolved
Hide resolved
ShirleyNekoDev
commented
Aug 8, 2023
ShirleyNekoDev
force-pushed
the
refactor/canvas-size
branch
from
20c058a
to
3caafe7
Compare
leMaik
reviewed
Aug 8, 2023
leMaik
reviewed
Aug 8, 2023
added 2 commits
November 6, 2023 17:05
# Conflicts: # chunky/src/java/se/llbit/chunky/renderer/export/PngExportFormat.java # chunky/src/java/se/llbit/chunky/renderer/scene/Scene.java # chunky/src/java/se/llbit/imageformats/tiff/TiffFileWriter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to reduce the size of the Scene class and is a step for implementing support for custom canvas buffers in the future.