Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native/date: Improve DelayedFormat doc re Panics #1590

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

behnam-oneschema
Copy link

@behnam-oneschema behnam-oneschema commented Jun 10, 2024

Since #[should_panic] kind of checks are not available for doctesting, cannot add a test for it in the current structure. The panic behavior probably could use a unit test somewhere else, if it doesn't exist yet.

See #1588

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.78%. Comparing base (2085627) to head (c299c18).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1590   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          37       37           
  Lines       18208    18208           
=======================================
  Hits        16713    16713           
  Misses       1495     1495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djc djc merged commit de2f1f4 into chronotope:main Jun 11, 2024
35 checks passed
@behnam-oneschema behnam-oneschema deleted the format-1 branch June 11, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants