Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

(GH-120) Extended rule to include whole nuspec #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Feb 17, 2016

  • Rather than looking at only Copyright and Authors, look at all
    properties in the nuspec
  • Include special handling for IEnumerable
  • Added additional tests to cover over properties

@gep13
Copy link
Member Author

gep13 commented Feb 17, 2016

Relates to #120

@gep13
Copy link
Member Author

gep13 commented Feb 17, 2016

@ferventcoder I have updated the wiki article to use the new name for this rule

@ferventcoder
Copy link
Member

You may want to keep around the old wiki link and point it to the new link. Otherwise it will be broken for folks who may come to this from the validator.

// NOTE: Not overally happy with this!
// Want to be able to each of the values in the IEnumerable, to then check if there is
// an email contained within one of them.
if (property.PropertyType.FullName.Contains("IEnumerable`1[[System.String"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Rather than looking at only Copyright and Authors, look at all
properties in the nuspec
- Include special handling for IEnumerable<string>
- Added additional tests to cover over properties
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants