Add stack overflow detection to sw-emulator #1785
Open
+218
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
force-pushed
the
stack-overflow-monitor
branch
from
6534995
to
15c3882
Compare
clundin25
requested review from
korran,
fdamato,
jlmahowa-amd,
mhatrevi,
jhand2,
swenson,
vsonims,
rusty1968,
bluegate010,
ajisaxena and
JohnTraverAmd
as code owners
clundin25
commented
Nov 14, 2024
clundin25
force-pushed
the
stack-overflow-monitor
branch
from
15c3882
to
c1836a9
Compare
clundin25
force-pushed
the
stack-overflow-monitor
branch
from
c1836a9
to
d6f8397
Compare
jhand2
reviewed
Dec 2, 2024
sw-emulator/lib/cpu/src/cpu.rs
Outdated
| /// Checks if the stack will overflow when pushed to `stack_address`. | ||
| /// | ||
| /// Returns `true` if the stack will overflow, `false` if it will not overflow. | ||
| pub fn check_overflow(&mut self, stack_address: u32) -> bool { |
There was a problem hiding this comment.
The stack info is only based on one fw stage (i.e. ROM, FMC, or RT). It's not clear to me how the emulator should know that the stack is relevant for a given fw stage.
Idk if this is too convoluted, but one thing we could do is have the stack tied to a certain ICCM range.
e.g. If PC is in range [A, B], SP must be in range [X, Y]
There was a problem hiding this comment.
I'll work on adding that change
There was a problem hiding this comment.
Updated to check multiple code ranges / stacks
clundin25
force-pushed
the
stack-overflow-monitor
branch
from
d6f8397
to
a99ab23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added stack monitoring and overflow detection to the SW emulator
If a stack overflow is detected, the emulator will panic and cause test failure.
This resolves #1735