Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][WRS-1190] Don't execute SDK load event if document is not loaded #237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix][WRS-1190] Don't execute SDK load event if document is not loaded #237

wants to merge 1 commit into from
+54 −36

Conversation

psamusev
Copy link
Contributor

@psamusev psamusev commented Nov 25, 2024 •
edited by jira bot
Loading

This PR

Related tickets

Screenshots

@psamusev psamusev requested a review from a team as a code owner November 25, 2024 13:09
@github-actions GitHub Actions
Copy link
Contributor

PR can be checked at https://stgrafxstudiodevpublic.blob.core.windows.net/studio-ui/pr_builds/237/index.html

@github-actions GitHub Actions
Copy link
Contributor

Coverage report can be checked at https://stgrafxstudiodevpublic.blob.core.windows.net/studio-ui/coverage_reports/237/coverage.html

@github-actions GitHub Actions
Copy link
Contributor

Test Results

124 tests   122 ✅  1m 31s ⏱️
 28 suites    2 💤
  1 files      0 ❌

Results for commit ac3060e.

@github-actions GitHub Actions
Copy link
Contributor

PR bundle size is 1.029 MB and 77.034 KB more than limit.

@psamusev psamusev added Ready for QA Defines that PR is ready for QA and removed Ready for QA Defines that PR is ready for QA labels Nov 25, 2024
@psamusev psamusev added Ready for QA Defines that PR is ready for QA and removed Ready for QA Defines that PR is ready for QA labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdelhalimkhouas abdelhalimkhouas abdelhalimkhouas approved these changes

@pietervp pietervp Awaiting requested review from pietervp pietervp is a code owner automatically assigned from chili-publish/react

@alexandraFlavia9 alexandraFlavia9 Awaiting requested review from alexandraFlavia9 alexandraFlavia9 is a code owner automatically assigned from chili-publish/react

@smereuta smereuta Awaiting requested review from smereuta smereuta is a code owner automatically assigned from chili-publish/react

Assignees
No one assigned
Labels
Ready for QA Defines that PR is ready for QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psamusev @abdelhalimkhouas